add image tag action #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drjova
reviewed
Aug 18, 2025
| - name: Tag and push images | ||
| shell: bash | ||
| run: | | ||
| TAG="${{ inputs.tag }}" |
Contributor
There was a problem hiding this comment.
it's not my favorite to review bash scripts 🙃
- I would move it to a separate file
- the
^(.+):.*$is greedy, but I guess we will not have corner cases with ports before tags, i.e.something:5000:latest
Author
There was a problem hiding this comment.
- Whats the difference? 😅 Kinda makes it less readable to open another file
- Yes it is, but i also dont think it matters. I tested the code with and image digest image (e.g
something@sha256:c462ccc) and with a normal tag (e.g.something:v1) and both work 👍
drjova
reviewed
Aug 18, 2025
Contributor
drjova
left a comment
drjova
left a comment
There was a problem hiding this comment.
@PascalEgn thank you added few comments, otherwise for me it's ok
PascalEgn
force-pushed
the
1032-add-image-tag-action
branch
2 times, most recently
from
8f7e9ec to
d7ce61a
Compare
PascalEgn
force-pushed
the
1032-add-image-tag-action
branch
from
d7ce61a to
6238bc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: cern-sis/issues-inspire#1032