Create role to deploy and configure MAAS by falcocer-ibm · Pull Request #788 · ceph/ceph-cm-ansible

falcocer-ibm · 2025-09-17T16:36:36Z

No description provided.

Signed-off-by: Fernando <fernando.alcocer.ochoa@ibm.com>

dmick · 2025-09-24T02:23:01Z

roles/maas/defaults/main.yml

@@ -9,6 +9,7 @@ postgres_version: "16"
 maas_version: "3.6"


commit message: this is a "task", not a module

I will squash all my commits later.

roles/maas/README.md

djgalloway · 2025-10-10T20:20:34Z

roles/maas/tasks/config_dhcpd_subnet.yml

+       existing_end_ips: "{{ ip_ranges_raw.stdout | from_json | map(attribute='end_ip') | list }}"
+
+   - name: Create IP Range for {{ subnet_name }} subnet
+     command: "maas {{ maas_admin_username }} ipranges create type={{ subnet_data.ip_range_type }} start_ip={{ subnet_data.start_ip }} end_ip={{ subnet_data.end_ip }}"


subnet= is also required

I am re-configuring all the DHCP task, because right now for our needs is useless.

Did you reconfigure the tasks?

djgalloway · 2025-10-10T20:25:55Z

roles/maas/tasks/config_dhcpd_subnet.yml

+       existing_start_ips: "{{ ip_ranges_raw.stdout | from_json | map(attribute='start_ip') | list }}"
+       existing_end_ips: "{{ ip_ranges_raw.stdout | from_json | map(attribute='end_ip') | list }}"


What was the design decision behind this? Why not search for the cidr in maas admin ipranges read output?

I am re-configuring all the DHCP task, because right now for our needs is useless.

djgalloway · 2025-10-10T20:31:10Z

roles/maas/tasks/config_dhcpd_subnet.yml

+
+   # This section verifies if the snippets already exist and creates the name variables
+   - name: Get current snippet names
+     command: bash -c "maas {{ maas_admin_username }} dhcpsnippets read"


Why not shell module?

I am re-configuring all the DHCP task, because right now for our needs is useless.

djgalloway · 2025-10-10T21:03:56Z

The README should mention that the MAAS server should have a network interface on every subnet prior to running the playbook. And why.

djgalloway · 2025-10-10T21:13:28Z

The ansible should handle:

Removing a reserved IP range from maas if it used to be in dhcp_maas_subnets: {} and isn't anymore

djgalloway · 2025-10-10T21:26:40Z

roles/maas/tasks/config_dhcpd_subnet.yml

+       vlan_id: "{{ (subnet_info.stdout | from_json).id }}"
+
+   - name: Enable DHCP on {{ subnet_name }} subnet
+     command: "maas {{ maas_admin_username }} vlan update {{ fabric_name }} {{ vlan_vid }} dhcp_on=True primary_rack={{ groups['maas_region_rack_server'][0].split('.')[0] }} secondary_rack={{ groups['maas_rack_server'][0].split('.')[0] }}"


primary_rack={{ groups['maas_region_rack_server'][0].split('.')[0] }} secondary_rack={{ groups['maas_rack_server'][0].split('.')[0] }}

Why?

I configured this playbook to run on at least 2 MAAS servers in order to have HA, that command enables DHCP on the region controller but in order to do the same on the secondary rack you need to run the command specifying the secondary rack.

djgalloway · 2025-10-15T13:24:30Z

roles/maas/tasks/config_maas.yml

+        mode: '0644'
+
+    - name: Check curtin scripts directory
+      shell: "ls {{ maas_home_dir }}/usr/lib/python3/dist-packages/curtin/commands/install_grub.py"


The stat module would be more appropriate

roles/maas/tasks/config_maas.yml

dmick · 2025-09-24T02:23:31Z

roles/maas/tasks/config_maas.yml

-          94_configure_sudo: ["curtin", "in-target", "--", "sh", "-c", "printf '%%sudo ALL=(ALL) NOPASSWD: ALL\nDefaults !requiretty\nDefaults visiblepw' >> /etc/sudoers.d/cephlab_sudo"]
-          96_create_ssh_directory: ["curtin", "in-target", "--", "sh", "-c", "mkdir -p /home/cm/.ssh"]
-          98_copy_ssh_keys_cm: ["curtin", "in-target", "--", "sh", "-c", "echo '{{ cm_user_ssh_keys|join('\n') }}' >> /home/cm/.ssh/authorized_keys"]
+        block: |2


why change the indent level and add this weird indent-removal character?

When you add the block inside the curtin script you need to use the exact indent level the file already has otherwise curtin will ignore those commands.

dmick · 2025-09-24T02:24:29Z

roles/maas/tasks/main.yml

@@ -49,15 +49,13 @@



why are these changes in this commit? config_maas.yml existed before the addition of console=, yes?

At the end I will just squash all my commits together, but you are right, I will try to separate my commits better in order to do this review process easier.

roles/maas/README.md

dmick · 2025-09-26T19:00:07Z

roles/maas/tasks/config_maas.yml

+      when: "maas_install_method == 'snap' and not maas_x1.stat.exists"
+      register: maas_snap
+
+    - name: Unsquahs MAAS FS


Still needs fixing

roles/maas/tasks/config_maas.yml

Signed-off-by: Fernando <fernando.alcocer.ochoa@ibm.com>

…hings and things that were added with the latest tasks. Signed-off-by: Fernando <fernando.alcocer.ochoa@ibm.com>

djgalloway · 2026-01-28T20:01:40Z

@falcocer-ibm is this ready to go now?

… of shell commands for improved reliability and clarity

Creating a new role to deploy and configure MAAS

be396ce

falcocer-ibm requested a review from dmick September 17, 2025 16:36

falcocer-ibm self-assigned this Sep 17, 2025

falcocer-ibm added 2 commits September 18, 2025 09:45

Include line to delete cm user pass on the curtin preseed.

0330175

Signed-off-by: Fernando <fernando.alcocer.ochoa@ibm.com>

Add new module to configure global kernel parameters

8e85a65

Signed-off-by: Fernando <fernando.alcocer.ochoa@ibm.com>

dmick changed the title ~~Creating a new role to deploy and configure MAAS~~ Create role to deploy and configure MAAS Sep 24, 2025

dmick reviewed Sep 24, 2025

View reviewed changes

djgalloway reviewed Oct 10, 2025

View reviewed changes

roles/maas/README.md Outdated Show resolved Hide resolved

djgalloway reviewed Oct 10, 2025

View reviewed changes

djgalloway reviewed Oct 15, 2025

View reviewed changes

roles/maas/tasks/config_maas.yml Show resolved Hide resolved

djgalloway reviewed Nov 6, 2025

View reviewed changes

roles/maas/tasks/config_maas.yml Show resolved Hide resolved

dmick requested changes Nov 6, 2025

View reviewed changes

falcocer-ibm added 2 commits November 12, 2025 11:08

Add command to create sudo group in curtin_userdata

f21ecae

Signed-off-by: Fernando <fernando.alcocer.ochoa@ibm.com>

Update the documentation in the README file to include some missing t…

7fa60a0

…hings and things that were added with the latest tasks. Signed-off-by: Fernando <fernando.alcocer.ochoa@ibm.com>

Refactor MAAS configuration tasks to use ansible.builtin.stat instead…

494ac49

… of shell commands for improved reliability and clarity

		existing_start_ips: "{{ ip_ranges_raw.stdout \| from_json \| map(attribute='start_ip') \| list }}"
		existing_end_ips: "{{ ip_ranges_raw.stdout \| from_json \| map(attribute='end_ip') \| list }}"

Comments

Conversation

falcocer-ibm commented Sep 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

djgalloway commented Oct 10, 2025

Uh oh!

djgalloway commented Oct 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

djgalloway commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants