Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 25, 2025

Remove unnecessary compatibility code for legacy Python 2 which is no longer supported.

Does the suggested change modify

new_entry = next(entry)

Remove unnecessary compatibility code for legacy Python 2 which is no longer supported.
@cclauss cclauss requested review from auvipy and Copilot August 25, 2025 07:49

This comment was marked as outdated.

@cclauss cclauss requested a review from Copilot August 25, 2025 08:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Python 2 compatibility code that is no longer needed since Python 2 has been deprecated. The changes modernize the codebase by removing legacy compatibility assignments and updating method calls to use Python 3 conventions.

  • Remove Python 2 compatibility alias for __next__ method
  • Update test to use built-in next() function instead of deprecated method call
  • Clean up unnecessary whitespace

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
django_celery_beat/schedulers.py Removes Python 2 compatibility alias next = __next__ and cleans up whitespace
t/unit/test_schedulers.py Updates test to use next(e2) instead of e2.next() method call

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.18%. Comparing base (628bbe2) to head (90d73ea).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
- Coverage   88.19%   88.18%   -0.02%     
==========================================
  Files          32       32              
  Lines        1008     1007       -1     
  Branches      105      105              
==========================================
- Hits          889      888       -1     
  Misses        101      101              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@auvipy auvipy merged commit c2c27d3 into main Aug 25, 2025
28 checks passed
@auvipy auvipy deleted the remove-python2-next-assignment branch August 25, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants