Implement Celeritas-DD4hep integration plugin #1756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahmans1
added
enhancement
Test summary 5 747 files 9 233 suites 16m 21s ⏱️ Results for commit e0ea2b5. ♻️ This comment has been updated with latest results. |
sethrj
reviewed
Apr 21, 2025
rahmans1
force-pushed
the
feature-dd4hep-integration-plugin
branch
from
b3e3fd5 to
ab67f02
Compare
rahmans1
force-pushed
the
feature-dd4hep-integration-plugin
branch
from
ccc0fca to
988047d
Compare
rahmans1
force-pushed
the
feature-dd4hep-integration-plugin
branch
from
6369a78 to
2d9531e
Compare
Contributor
Author
|
@sethrj This implementation is pretty preliminary based on streamlining the multiple test beds I was working on. I decided to use the OpenDataDetector from acts-project for validation as it should be a simpler approximation to something like the EIC ePIC geometry. Build and run instructions are inside the steeringFile.py. I can see celeritas logs but haven't validated the output yet. |
wdconinc
reviewed
May 29, 2025
wdconinc
reviewed
May 29, 2025
Contributor
Author
|
Running with gdb to investigate segfaults gives: |
Contributor
Author
|
Building Geant4 Building DD4hep Building celeritas Running with gdb Complete backtrace |
Contributor
Author
|
sethrj
reviewed
Jun 26, 2025
Contributor
Author
|
With changes to the hit processor (#1835), we can see some hits in the ODD ecal if we ignore saving MC truth particle info in edm4hep output.
Now we need to consider the following:
|
Validation benchmarks have been moved to the benchmarks repository. The example directory now only contains geometry and steering files for running simulations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Remove SiD geometry and run script - Add Preshower geometry (Preshower.xml) and steering file to input/ directory - Add run-preshower.sh script with mode selection (celeritas/geant4) - Update CI workflow to run preshower simulation with 3 events and fixed random seed - Update artifact paths to match new results directory structure 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replace invalid $<TARGET:...> generator expression with $<TARGET_LINKER_FILE:...> to correctly link the CUDA RDC final library into DD4hep plugins. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This reverts commit d8ee573.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1731