-
Notifications
You must be signed in to change notification settings - Fork 34
Sync overlays through traits #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
3fdcb10 to
0013030
Compare
0013030 to
5797384
Compare
2270b2b to
4e887fc
Compare
|
It works. My only remarks are:
|
I am not sure if this can cause a real issue in practice. I think we should test loading a big MOC, fits image or catalog votable that is currently well handled in master and see if it is not in this branch. If there are problems we could maybe try evaluating the size of the overlay and send an event or not depending on it.
I think we should do that in another PR maybe ? on the JS side one can call https://cds-astro.github.io/aladin-lite/Aladin.html#removeOverlay with the name of overlay to remove. |
* fix the documentation examples. overlays do correctly appear on the generated HTML static file because is its passed with traitlets instead of being sent with events. * if the user want to export the aladin view to HTML, using embed_minimal_html from ipywidgets do recognize the add of overlays * add of colormap traitlet to replace the old event * bind projection change with the change on the python side (aladin.projection)
7a69736 to
f951982
Compare
Bumps [vega-selections](https://github.com/vega/vega) from 5.6.0 to 5.6.3. - [Release notes](https://github.com/vega/vega/releases) - [Commits](https://github.com/vega/vega/commits) --- updated-dependencies: - dependency-name: vega-selections dependency-version: 5.6.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [systeminformation](https://github.com/sebhildebrandt/systeminformation) from 5.23.14 to 5.27.14. - [Changelog](https://github.com/sebhildebrandt/systeminformation/blob/master/CHANGELOG.md) - [Commits](sebhildebrandt/systeminformation@v5.23.14...v5.27.14) --- updated-dependencies: - dependency-name: systeminformation dependency-version: 5.27.14 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
This is based on the first cleanup done in #150
This contains:
current online documentation (no overlays are showed):
now:
embed_minimal_htmlfrom ipywidgets does recognize the add of overlaysTo export the aladin object to html through ipywidgets:
This gives this html file with the table overlays correctly contained in it:
