chore: change package entry point to lib/library/index.js#54
Merged
cdklabs-automation merged 2 commits intomainfrom Nov 21, 2025
Merged
chore: change package entry point to lib/library/index.js#54cdklabs-automation merged 2 commits intomainfrom
cdklabs-automation merged 2 commits intomainfrom
Conversation
kaizencc
reviewed
Nov 21, 2025
.projenrc.ts
Outdated
| bin: { | ||
| 'cdk-construct-analyzer': './bin/cdk-construct-analyzer', | ||
| }, | ||
| entrypoint: 'lib/lib/index.js', |
Contributor
There was a problem hiding this comment.
whoah, why lib / lib? that seems wrong. lets chat about it
Contributor
There was a problem hiding this comment.
ok i think i understand -> lets do the following
- change the
libfolder intolibrarybecauselib, while short forlibraryhas a separate convention that makes things confusing - do you aim to release only the library? what about the cli? i think its fine for now, so the entrypoint should be
lib/library/index.js, but its not great
Contributor
Author
There was a problem hiding this comment.
I renamed the lib folder to library
Contributor
Author
There was a problem hiding this comment.
I'm confused, can you explain why the entrypoint lib/library/index.js is not great? I'm currently under the impression that both the CLI and library will be released when I publish
huang-benny
changed the title
kaizencc
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the package entry point from
lib/index.jstolib/library/index.jsto align with the project's build output structure.Changes
.projenrc.tsto setentrypoint: 'lib/library/index.js'package.jsonvia projen