Skip to content

Comments

refactor: update display name format#45

Merged
cdklabs-automation merged 1 commit intomainfrom
behuang/fix_display_name
Nov 11, 2025
Merged

refactor: update display name format#45
cdklabs-automation merged 1 commit intomainfrom
behuang/fix_display_name

Conversation

@huang-benny
Copy link
Contributor

Changed signal naming convention from parentheses to underscores, allowing signal names to be used as valid JavaScript object keys without quotes.

Previously, signal names like numberOfContributors(Maintenance) required quotes when used as object keys

signalScores: {
  MAINTENANCE: {
    'numberOfContributors(Maintenance)': 4, 
  }
}

Now with underscores, they work as valid identifiers:

signalScores: {
  MAINTENANCE: {
    numberOfContributors_Maintenance: 4,  // ✅ No quotes needed
  }
}

Changes

  • Updated convertToDisplayName() to convert underscores to dashes for display
  • Signal names now use underscores: numberOfContributors_Maintenance
  • Display output uses dashes: Number Of Contributors - Maintenance

There are no other changes to the CLI input or output.

@cdklabs-automation cdklabs-automation added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit 0bd84bd Nov 11, 2025
8 checks passed
@cdklabs-automation cdklabs-automation deleted the behuang/fix_display_name branch November 11, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants