-
Notifications
You must be signed in to change notification settings - Fork 1
Refactored and updated #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasonshortphd
wants to merge
15
commits into
cavehs:master
Choose a base branch
from
jasonshortphd:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed HTML page. Seeded random to ensure uniqueness Going to have to cleanup the goto code blocks.
Remove HTML
Using Crypto RNG Refactored to include more options Remove duplicate characters Changed the way choices are made to include larger search space
Added icon
Minor change to upgrade to 4.8.
Remove Random() allocation since we are using RNG class now. And it should be recreated to ensure new seed each time.
This will be easier to take the code to a service backend at some point, and to add unit tests.
Class has been deprecated...
used upgrade asst to upgrade the solution
Some sites won't accept a non letter first password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the code to use the Crypto RNG rather than just random.
Also changed the way the characters are chosen. The old way had too much bias in the way they were selected.
Added an about screen (HTML would not launch).
Added an icon.