Skip to content

Conversation

@rhell4
Copy link

@rhell4 rhell4 commented Dec 22, 2025

This makes three changes:

  1. There was an issue where fetchExternalData needs to be called first passing true for the $stream param before the download path is set. We can then get the path that was used after with getUploadedH5pPath, instead of the other way around that we had before. d4d2400
  2. I found some libraries were not being curled within the 5 minute timeout set, I even tried a much longer timeout and still no luck. Eventually when I came back to the issue a few weeks later it seemed to be fine, so I suspect there might have been something on the H5P hub end. To handle this better I have moved the updating to adhoc tasks which will be spawned from update_libraries.php for each library that needs updating. This way any problematic libraries will not block other libraries from updating and can be retried later. 5916cb9
  3. We used to only check the major and minor version (x.x) when checking which libraries need updating. We want to also check the patch version (x.x.x) to get patch version updates, instead of just updating when there is a new minor version. 3581398

@rhell4 rhell4 force-pushed the fix-bulk-update-libraries branch from 934d427 to 3d027c7 Compare December 22, 2025 05:29
@rhell4 rhell4 force-pushed the fix-bulk-update-libraries branch 2 times, most recently from 1ee6e66 to 90e5cfa Compare December 22, 2025 06:25
@rhell4 rhell4 force-pushed the fix-bulk-update-libraries branch from 90e5cfa to 3581398 Compare December 22, 2025 06:56
@rhell4
Copy link
Author

rhell4 commented Dec 22, 2025

As a note, during some more testing I was doing, fetching the data for Agamotto (Image Blender) was timing out. This was working earlier with no issues and the other libraries I had queued to upgrade at the time completed with no issues. So while the root issue isn't fixed (not sure if it's a Moodle issue or just a H5P hub issue) the adhoc tasks will allow the rest of the libraries to at least update.

@Peterburnett Peterburnett merged commit 3bafef7 into stable-catalyst Dec 22, 2025
23 checks passed
@Peterburnett Peterburnett deleted the fix-bulk-update-libraries branch December 22, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants