Skip to content

Conversation

@ScottVerbeek
Copy link

Commit fb62787 contains the following h5p/h5p-php-library@fb62787#diff-89117fe225bccb930971b72569064b31f631ae2b7a717300b4cf2845fb14ec6eR4859-R4864 . This will cause a unit test failure in MDL39.

1) core_h5p\api_testcase::test_get_export_info_from_context_id
Unexpected debugging() call detected.
Debugging: String translation cannot be found. Please add a string definition for 'Assistive Technologies label' in the core_h5p component.

/var/www/site/lib/phpunit/classes/advanced_testcase.php:88

To re-run:
 vendor/bin/phpunit "core_h5p\api_testcase" h5p/tests/api_test.php

@ScottVerbeek ScottVerbeek force-pushed the unittest-fix-stable-catalyst branch from 332cdcc to 2971276 Compare February 2, 2021 01:01
@ScottVerbeek ScottVerbeek changed the title Checked out library before fb62787 Reverted commits made in Pull request #3 Feb 2, 2021
@ScottVerbeek
Copy link
Author

Reverted commits made in Pull request #3

@ScottVerbeek ScottVerbeek force-pushed the unittest-fix-stable-catalyst branch from 2971276 to b651a5e Compare February 2, 2021 01:21
@ScottVerbeek ScottVerbeek changed the title Reverted commits made in Pull request #3 Backport from h5p master Feb 2, 2021
@Peterburnett Peterburnett merged commit d9f71c1 into stable-catalyst Feb 2, 2021
@Peterburnett Peterburnett deleted the unittest-fix-stable-catalyst branch February 2, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants