Skip to content

Conversation

@hparkertt
Copy link
Contributor

Resolves #47

@hparkertt
Copy link
Contributor Author

@caseycesari Any thoughts on taking a look at this? 631ef53 should be straightforward enough. f9e7f50 isn't really necessary, it's just a quick fix for the jshint task.

@caseycesari
Copy link
Owner

@hparkertt Hey, thanks for the reminder, and the fix. Any chance you could add a test? If not, I can add one this week and get this released. Thanks.

@hparkertt
Copy link
Contributor Author

hparkertt commented Oct 1, 2019

@caseycesari The tests are in, but I noticed a limitation of GeoJSON that I might try and fix right off. The limitation is that you cannot specify multiple geometry mappings in the param object that do not have similar nested property paths. The buildGeom function returns false at line 234 and at line 252, not allowing the params.geom loop to continue and attempt to find a matching nested property path with a different geometry type.

EDIT: See #49

@hparkertt
Copy link
Contributor Author

Hi @caseycesari I've added a few issues that can be labeled as 'enhancements'. I probably could have done it a little cleaner, but I've created pull requests for each issue. Overall, here is what I've done:

At this point we should focus discussion for each issue in it's own page; I only listed this out here because this is where our conversation started. This library is a really great, simple tool, and I hope these changes help give it a little extra functionality!

Thanks!

@caseycesari
Copy link
Owner

@hparkertt Oh wow! Thanks for all of these PRs. I'm going to try and get through these over the next couple days.

@caseycesari
Copy link
Owner

This looks good. Merging.

@caseycesari caseycesari merged commit ec62bfa into caseycesari:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot call hasOwnProperty of null on itemClone

2 participants