-
Notifications
You must be signed in to change notification settings - Fork 6
Automatically log out of Casdoor when logging out of WordPress #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…oor-login [WIP] Update Casdoor login handling for redirect preservation and security
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
=========================================
Coverage ? 20.15%
Complexity ? 52
=========================================
Files ? 4
Lines ? 258
Branches ? 0
=========================================
Hits ? 52
Misses ? 206
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't have confidence about your AI output for this PR. |
|
There's no doubt both this PR and the previous one are significantly more secure. Did you come across any issues during testing? While it's true that the entire plugin could benefit from a complete rebuild, especially since there are many missing features and areas that aren’t ideal, I’ve tested all the recent changes and they’re working well. I’m using it in production right now and had a few more PRs planned. I felt it was the right decision to get involved and dedicate my time to supporting a project I’m actively using in a more official way. However, it’s much easier for me to focus on my own development, so just let me know what your plans are for this project. Given the lack of updates and activity, it seems like this plugin is abandoned. |
|
@7encoder I can't understand your code. You generated it with AI. You probably don't even know what code you are committing, just like the last time. I told you that the PR code is a mess, then you re-generate a new piece code with AI and submit it in new PR. Maybe AI code is not totally useless, but it's hard for me to tell and review. |
|
I won’t go into an extended explanation, but yes, I did use AI, and it performed exactly as I instructed. You can verify this by checking the code. It’s a bit puzzling that you’re claiming you did the checking, especially since the code is commented, but it seems like you didn’t fully understand it. Perhaps the part that caused confusion is the Force SSL verification feature. This option was added as an optional it in the backend to enhance basic security. Apart from that, the main change was to ensure that users are automatically logged out of Casdoor when they log out of WordPress. When I submitted the previous PR, I don't think you checked the code and ended up closing it. The only other modification I made was to update the plugin version, since the current versioning implementation is incorrect and doesn’t follow proper standards. Everything I sent has been thoroughly inspected, tested, and is working as expected. However, it’s open for you to improve if you care. |
No description provided.