Skip to content

Conversation

@7encoder
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ 7encoder
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 2.08333% with 47 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@5f9cd6f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
Casdoor.php 2.38% 41 Missing ⚠️
includes/admin-options.php 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage          ?   20.15%           
  Complexity        ?       52           
=========================================
  Files             ?        4           
  Lines             ?      258           
  Branches          ?        0           
=========================================
  Hits              ?       52           
  Misses            ?      206           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hsluoyz
Copy link
Member

hsluoyz commented Oct 23, 2025

I don't have confidence about your AI output for this PR.

@7encoder
Copy link
Contributor Author

There's no doubt both this PR and the previous one are significantly more secure.

Did you come across any issues during testing?

While it's true that the entire plugin could benefit from a complete rebuild, especially since there are many missing features and areas that aren’t ideal, I’ve tested all the recent changes and they’re working well. I’m using it in production right now and had a few more PRs planned.

I felt it was the right decision to get involved and dedicate my time to supporting a project I’m actively using in a more official way. However, it’s much easier for me to focus on my own development, so just let me know what your plans are for this project. Given the lack of updates and activity, it seems like this plugin is abandoned.

@hsluoyz
Copy link
Member

hsluoyz commented Oct 23, 2025

@7encoder I can't understand your code. You generated it with AI. You probably don't even know what code you are committing, just like the last time. I told you that the PR code is a mess, then you re-generate a new piece code with AI and submit it in new PR. Maybe AI code is not totally useless, but it's hard for me to tell and review.

@7encoder
Copy link
Contributor Author

I won’t go into an extended explanation, but yes, I did use AI, and it performed exactly as I instructed. You can verify this by checking the code. It’s a bit puzzling that you’re claiming you did the checking, especially since the code is commented, but it seems like you didn’t fully understand it.

Perhaps the part that caused confusion is the Force SSL verification feature. This option was added as an optional it in the backend to enhance basic security. Apart from that, the main change was to ensure that users are automatically logged out of Casdoor when they log out of WordPress.

When I submitted the previous PR, I don't think you checked the code and ended up closing it. The only other modification I made was to update the plugin version, since the current versioning implementation is incorrect and doesn’t follow proper standards. Everything I sent has been thoroughly inspected, tested, and is working as expected. However, it’s open for you to improve if you care.

@7encoder 7encoder deleted the 7encoder-patch-1 branch October 24, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants