Skip to content

Conversation

@7encoder
Copy link
Contributor

@7encoder 7encoder commented Oct 21, 2025

Fix: #22

Copilot AI and others added 15 commits October 19, 2025 22:29
…oor-login

[WIP] Update Casdoor login handling for redirect preservation and security
Added redirect preservation for CASdoor login.
Added 'auto_sso' and 'active' options to avoid undefined key warnings and maintain consistent behavior. Updated return types and added new functions for URL handling and redirect resolution.
Good comments by Copilot

Co-authored-by: Copilot <[email protected]>
Better readability

Co-authored-by: Copilot <[email protected]>
More comments

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Updated the callback URLs section to include an additional URI.
Refactor callback handling for OAuth login process, improving security and user flow.
Updated version number and added logout functionality with token handling.
Updated version number and added logout functionality with token handling.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ 7encoder
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

@hsluoyz
Copy link
Member

hsluoyz commented Oct 22, 2025

@7encoder need to pass CI checks:

image

Refactor Casdoor class to improve version handling and method structure.
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 9.61538% with 47 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@5f9cd6f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
Casdoor.php 10.00% 45 Missing ⚠️
includes/admin-options.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #28   +/-   ##
=========================================
  Coverage          ?   21.48%           
  Complexity        ?       47           
=========================================
  Files             ?        4           
  Lines             ?      242           
  Branches          ?        0           
=========================================
  Hits              ?       52           
  Misses            ?      190           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Define CASDOOR_PLUGIN_VERSION for test consistency.
Add newline at the end of the file for consistency.
Updated the version assertion to use the constant CASDOOR_PLUGIN_VERSION.
@7encoder
Copy link
Contributor Author

It was complaining about the plugin version, it should be fixed now.

@hsluoyz
Copy link
Member

hsluoyz commented Oct 22, 2025

@7encoder it's too big PR. I suggest you only committing code that are related to the topic: auto logout

@hsluoyz hsluoyz closed this Oct 22, 2025
@hsluoyz
Copy link
Member

hsluoyz commented Oct 22, 2025

One topic, one PR

@7encoder 7encoder deleted the redirect-updates branch October 22, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The plugin does not log users out of the Casdoor application when they log out of WordPress.

3 participants