fix: associate revision to Istio control plane #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Libraries: Out of sync
MattiaSarti
changed the title
This was referenced Jan 28, 2026
misohu
reviewed
Jan 29, 2026
Member
misohu
left a comment
misohu
left a comment
There was a problem hiding this comment.
Nice job. Added some comments. Also please to the original issue add the logs from github action run (logs are not stored for long time in action's run). Its nice to have actual error message in the issue :)
Contributor
Author
Good idea, @misohu! |
Contributor
Author
|
note: commits due to review comments will be backported after all review comments are resolved |
misohu
approved these changes
Jan 30, 2026
MattiaSarti
added a commit
that referenced
this pull request
Jan 30, 2026
* fix: parametrize logs correctly * ci: configure Cilium for Istio * test: cover Istio CNI enablement * test: fix argument parsing * fix: rectofy log message * fix: debug via logs * style: compact multi-line instruction * fix: make warning about missing revision disappear * fix: make warning about missing revision disappear by fixing tag * Revert "fix: make warning about missing revision disappear by fixing tag" This reverts commit a57ff80. * fix: use default name for revision * fix: manipulate output of istioctl directly * test: fix test cases with string-to-byte mocking * fix: apply revision instead of workaround * fix: remove old code block * fix: use default revision name * fix: fix typo * fix: typos * ci: remove spurious conditional * docs: add explanation for default revision
MattiaSarti
added a commit
that referenced
this pull request
Jan 30, 2026
* fix: parametrize logs correctly * ci: configure Cilium for Istio * test: cover Istio CNI enablement * test: fix argument parsing * fix: rectofy log message * fix: debug via logs * style: compact multi-line instruction * fix: make warning about missing revision disappear * fix: make warning about missing revision disappear by fixing tag * Revert "fix: make warning about missing revision disappear by fixing tag" This reverts commit a57ff80. * fix: use default name for revision * fix: manipulate output of istioctl directly * test: fix test cases with string-to-byte mocking * fix: apply revision instead of workaround * fix: remove old code block * fix: use default revision name * fix: fix typo * fix: typos * ci: remove spurious conditional * docs: add explanation for default revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #680
note: commits up to a5f6d26 introduce integration tests to catch the problem, the CI run corresponding to that commit reproduces it, and the subsequent commits apply the fix described in the linked issue