[codex] fix prebuild project name replacement#689
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
thymikee
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a
rock prebuildregression in@rock-js/plugin-expo-config-pluginswhere native placeholders were replaced using the project root folder name instead of the app name fromapp.json.It also includes test coverage updates to avoid case-sensitivity mismatch between local development (often case-insensitive filesystems) and Linux CI (case-sensitive filesystem).
User Impact
Users whose repository folder name differs from their configured app name could end up with incorrectly renamed native iOS artifacts after running
rock prebuild(for example, native project files named after the parent directory likeMobile).In addition, CI Validate could fail while local runs passed because fallback path assertions used incorrect casing.
Root Cause
regenNativeDirsusednormalizeProjectName(path.basename(projectRoot))when replacing placeholders, which ignoredapp.jsonname configuration.regen-native-dirs.test.tsused lowercase path casing that was not valid on case-sensitive CI filesystems.Fix
app.jsonfirst (expo.name, otherwise top-levelname) and only fall back to directory name when unavailable.replacePlaceholder.Validation
pnpm --filter @rock-js/plugin-expo-config-plugins exec vitest run src/lib/utils/regen-native-dirs.test.ts