fix: support newest MLC on iOS, fix isAvailable check on Android#192
Merged
fix: support newest MLC on iOS, fix isAvailable check on Android#192
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Nice improvements! Let me know when this is ready! |
Contributor
Author
|
Absolutely! Finishing the last pieces, somehow this is crashing on iOS - I need to dive deeper into this |
…n of the JSONFFIEngine
Contributor
Author
|
@grabbou it's R4R now! |
artus9033
changed the title
azizbecha
pushed a commit
to azizbecha/react-native-ai
that referenced
this pull request
Feb 13, 2026
…lstackincubator#192) * feat: support newest MLC on iOS * fix: update MLCEngine.mm to properly handle responses & initialization of the JSONFFIEngine * fix: mlcModelSetupAdapter isAvailable to work on iOS * fix: revert change of model for iOS * chore: sort imports * fix: use getFilesDir on MLC Android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for newest MLC branch on iOS by downstreaming newest changes to the FFI engine, but also updates the
MLCEngineto match the new API.It also makes the Android MLC wrapper implementation use
getFilesDirinstead ofgetExternalFilesDirto check for model existence, to have a common JS logic for both platforms.It also fixes an inconsistency in iOS model JSON config that included a different Qwen model than on Android, making it unusable in the demo app.