Fix 4 test suite bugs, use lab runners for push CI#56
Merged
Conversation
- Add `from __future__ import annotations` to test_consolidated_decorator.py (fixes Python 3.9 collection crash from PEP 604 `str | None` syntax) - Use unique namespaces per parametrize case in consolidated decorator tests (fixes cache isolation bug where [None] case hit stale data from earlier runs) - Update numpy array test to reflect constrained array support added in round-table review 2025-12-18 (1D, ≤100KB, supported dtypes) - Fix error message regex matches for datetime/set type rejection (messages were improved to be type-specific but tests weren't updated) - Run test matrix on self-hosted `cachekit` runners for push events (consistent perf results on Ryzen 5950X, ubuntu-latest for PRs)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from __future__ import annotationstotest_consolidated_decorator.py— PEP 604str | Nonesyntax crashed collection on 3.9[None]case was hitting stale cached data from[minimal]/[production]runstest_blake2b_with_numpy_arrays_raises_type_errorexpected arrays to be rejected, but constrained array support was added (round-table 2025-12-18). Now tests valid arrays succeed and invalid (2D) arrays are rejectedcachekitrunners on push (consistent perf on Ryzen 5950X),ubuntu-lateston PRs (untrusted code never touches lab)Test plan
ubuntu-latest(this run)test_all_feature_combinations_*[None]passescachekitself-hosted runners