Fix bug: part optional value is not used when parent part is bumped#186
Open
florisla wants to merge 5 commits intoc4urself:masterfrom
Open
Fix bug: part optional value is not used when parent part is bumped#186florisla wants to merge 5 commits intoc4urself:masterfrom
florisla wants to merge 5 commits intoc4urself:masterfrom
Conversation
This makes the upcoming unit test a little shorter.
This way, the optional_value can be used when required.
If you reverse the order, funny behavior ensues.
markmacode
approved these changes
Jan 22, 2021
Contributor
markmacode
left a comment
markmacode
left a comment
There was a problem hiding this comment.
Unit test looks good, works as expected.
I also did a manual test just to be sure, I was having this same issue the bug describes, this fixed it.
Collaborator
Author
|
Thanks for looking at this! This should definitely make it into the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #134