Not rewriting config file when bumping#162
Closed
balrok wants to merge 4 commits intoc4urself:masterfrom
Closed
Conversation
there are backwards incompatible changes right now: * when current_version did not exist in .bumpversion.cfg, it will not be created: * when retrieving the version from the git tag * when retrieving the version via --current_version flag * when .bumpversion.cfg contains a "new_version" field, previously this field was removed, but with this change it is not possible anymore
Contributor
Author
|
I found a third option, which avoids breaking backwards comaptibility. Closing it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since pr #90 stalled, I fixed the missing tests. By doing that, it also uncovered some regressions.
field was removed, but with this change it is not possible anymore
Solutions:
Not staying backwards compatible, because:
Staying backwards compatible, but being less intuitive:
Additionally, write the file whenever case 1 or 2 is true. This can be implemented by letting _load_configuration return a boolean.
This would solve:
And would simplify the implementation for pyproject.toml (PEP 518) support #42, since only a toml-parser but not printer is required