fix: use glob for go_library srcs in BUILD.bazel#278
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Apr 4, 2026
Merged
Conversation
The srcs list was hand-maintained and fell out of sync when v43 split code into feature-gated files (config_feat_*.go, linker_feat_wasi.go, module_feat_cranelift.go, store_feat_wasi.go, etc.). This caused Bazel builds to fail with undefined symbol errors since the new files were never added to srcs. Switch to glob() to match the pattern already used for go_test srcs, so new source files are automatically picked up.
alexcrichton
approved these changes
Apr 4, 2026
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! I'll work on releasing this on Monday
Contributor
Author
Any movement on this? |
Member
|
Apologies this totally slipped my mind, tagged now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The srcs list was hand-maintained and fell out of sync when v43 split code into feature-gated files (
config_feat_*.go,linker_feat_wasi.go,module_feat_cranelift.go,store_feat_wasi.go, etc.). This causes Bazel builds to fail with undefined symbol errors since the new files were never added to srcs.Switch to
glob()to match the pattern already used forgo_testsrcs, so new source files are automatically picked up.Would also appreciate cutting a v43.0.2 with this when merged.