wit-parser: extend WasmImport for future/stream intrinsics#2454
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Mar 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2409.
The intention is to hope that in
wit-bindgen, we no longer need to concat strings to make up the name ourselves. And this hopefully can make the transition easier from the legacy naming to the standard32 naming.Summary
wit_parser::WasmImportwithFutureIntrinsicandStreamIntrinsicvariants.FutureIntrinsic/StreamIntrinsicenums inwit-parser.Resolve::wasm_import_namesupport for these intrinsic imports under legacy mangling.Standard32unsupported for future/stream intrinsics with an explicit message (current model is sync-only).wit-componentdummy module generation to keep declarative import templates while sourcing intrinsic names fromresolve.wasm_import_name(...).Validation
cargo clippy -p wit-parser --all-targets -- -D warningscargo clippy -p wit-component --all-targets -- -D warningscargo test -p wit-parser wasm_import_name_future_and_stream_intrinsicscargo test -p wit-component