Skip to content

Conversation

@atomczak
Copy link
Member

No description provided.

@atomczak
Copy link
Member Author

I'm trying to remove the TODOs from the docs, and among them found this:

⚠️TODO: in the documentation we will be explicit that traversing IfcRelDecomposition for the purpose of material evaluation will not be implemented in 1.0. We need to define what is the behaviour when it comes to the IfcRelDecomposition and the propagation of materials.

As far as I remember, IfcRelAggregates (a subclass of IfcRelDecomposes) is permitted and the checkers should traverse, for example, IfcBuildingElementPart. Am I wrong? @CBenghi, @andyward, @Moult, @pasi-paasiala
If not allowed in 1.0, I suggest to reconsider for 1.1

@atomczak
Copy link
Member Author

@CBenghi, as agreed, I split the facet configuration doc into individual facets and merged with other docs.

@atomczak atomczak marked this pull request as ready for review May 23, 2025 11:56
@atomczak atomczak requested a review from CBenghi May 23, 2025 13:07
@CBenghi
Copy link
Contributor

CBenghi commented May 27, 2025

Apologies, it's a bit of a busy week, @atomczak
I'll get to review this soon.

@atomczak atomczak requested a review from youshengCode July 22, 2025 14:28
Copy link
Contributor

@andyward andyward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments

@atomczak atomczak requested a review from berlotti August 7, 2025 09:17
Copy link
Member

@berlotti berlotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@atomczak atomczak merged commit 6705c99 into buildingSMART:development Sep 8, 2025
1 check passed
@atomczak atomczak deleted the facet-docs branch September 8, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants