Remove incomplete plan from cache when compilation fails#137
Open
dbrain wants to merge 1 commit intobufbuild:mainfrom
Open
Remove incomplete plan from cache when compilation fails#137dbrain wants to merge 1 commit intobufbuild:mainfrom
dbrain wants to merge 1 commit intobufbuild:mainfrom
Conversation
|
|
bluespore
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an unregistered rule is hit during planning a
CompilationErroris thrown (as of #106), when this happens the partial plan stays in the message cache so next time through it picks up the partial cache and returns the incomplete plan.In our case this resulted in:
This catches the error and removes the incomplete message from the cache so it will fail again consistently.