Internationalization #20
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up internationalization using i18next library and its integration with React. Extract translation strings from Login and Home pages.
Extract translation strings from SearchBooks page and Footer. Add namespace and interpolation related init config for i18next.
Extract translation strings from EditBook by reusing those from AddBook as much as possible.
Antolius
force-pushed
the
internationalization
branch
from
1c02074 to
9f26230
Compare
Merge login translation strings into common.json and extract translation from the error page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #17
For now this is just a draft for implementing internationalization using the i18next library. Please provide feedback on the structure of the code, organization of translation files or anything else.
This is still far from done. Strings need to be extracted from:
And UI for manually choosing the locale needs to be implemented.