Fix incorrectly implemented show commands
#192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple arguments were issued to a `show` command, the expected behaviour is to make multiple API requests to get the full API data with all the data as exposed. Some commands had incorrectly been implemented using the main index API call which includes lightweight responses which results in incorrect output as fields were missing in the output since they are not in the response. Passing no arguments should have been an error but these variants would sometimes return ALL resources in the abridged format missing some fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple arguments were issued to a
showcommand, the expected behaviour is to make multiple API requests to get the full API data with all the data as exposed.Some commands had incorrectly been implemented using the main index API call which includes lightweight responses which results in incorrect output as fields were missing in the output since they are not in the response.
Passing no arguments should have been an error but these variants would sometimes return ALL resources in the abridged format missing some fields.