Refactor attributes and to_row
#190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be using the superclass version of these rather than repeating the same reference repeatedly. Since `Api#attributes` returns an `IndifferentAccessHash` which the `hirb` table code fails with, it is better to use `#merge` to assemble the table `#to_row` contents.
tokengeek
force-pushed
the
refactor_attributes
branch
from
1ed7b5b to
417fb32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be using the superclass version of these rather than repeating the same reference repeatedly.
Since
Api#attributesreturns anIndifferentAccessHashwhich thehirbtable code fails with, it is better to use#mergeto assemble the table#to_rowcontents.