Wrap Api#attributes with indifferent key access
#188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of bugs have been introduced or missed due to the way attributes are exposed by fog. Fog transforms the top level of attributes from the JSON sources (String) to Symbols, but does not act recursively. This results in accessing nested structures with a mix of Symbol and String keys which inevitably is missed or incorrectly specced out. This adds a simple wrapper around `Api#attributes` that takes the fog attributes and allows indifferent access with Symbols or Strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of bugs have been introduced or missed due to the way attributes are exposed by fog. Fog transforms the top level of attributes from the JSON sources (String) to Symbols, but does not act recursively.
This results in accessing nested structures with a mix of Symbol and String keys which inevitably is missed or incorrectly specced out.
This adds a simple wrapper around
Api#attributesthat takes the fog attributes and allows indifferent access with Symbols or Strings.