Stabilise tests when using DEBUG #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of specs would fail when `DEBUG` is passed as they were testing for no output on STDERR. Debug floods STDERR with debugging output causing using the tests and DEBUG together to be overwhelmed by inaccurate results. This either makes those failing specs conditional or updates to use `include` to spot the expected output within STDERR rather than being equal to it, allowing any debugging output to pass by.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of specs would fail when
DEBUGis passed as they were testing for no output on STDERR. Debug floods STDERR with debugging output causing using the tests and DEBUG together to be overwhelmed by inaccurate results.This either makes those failing specs conditional or updates to use
includeto spot the expected output within STDERR rather than being equal to it, allowing any debugging output to pass by.