Skip to content

Conversation

@lovelock
Copy link

@tkanos
Copy link

tkanos commented Mar 25, 2020

Thanks @lovelock, It will be appreciated for McRouter with replication.

McRouter with replication gives us for gets an error :

SERVER_ERROR unexpected result mc_res_unknown (0) for get

I will use your branch waiting the merge of @bradfitz

Thanks,

@lovelock
Copy link
Author

Thanks @lovelock, It will be appreciated for McRouter with replication.

McRouter with replication gives us for gets an error :

SERVER_ERROR unexpected result mc_res_unknown (0) for get

I will use your branch waiting the merge of @bradfitz

Thanks,

my pleasure

@eivindam
Copy link

Will this change be merged?

@bradfitz bradfitz removed the cla: yes label Sep 4, 2023

func (c *Client) getFromAddr(addr net.Addr, keys []string, cb func(*Item)) error {
cmd := "gets"
if c.DisableCAS {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the meat of this PR is here... the DisableCAS bool that changes the command sent.

@dormando
Copy link
Collaborator

dormando commented Apr 4, 2025

I like the concept of not using the CAS-y commands by default (didn't realize that was what was happening), however this PR has a lot of unrelated changes.

I'm guessing the user is long gone, but if the PR could be reduced to just the intended change it would have a better chance.

@dormando dormando added this to the Small protocol issues milestone Apr 4, 2025
@mrauer
Copy link

mrauer commented Apr 6, 2025

Simple: #192 @dormando

@lovelock
Copy link
Author

lovelock commented Apr 7, 2025

I like the concept of not using the CAS-y commands by default (didn't realize that was what was happening), however this PR has a lot of unrelated changes.

I'm guessing the user is long gone, but if the PR could be reduced to just the intended change it would have a better chance.

Oh I didn't realized that all the changes I've made after this PR were all synced here. In fact the initial commit was like what @mrauer did, see 1af313e, but the author didn't want to merge that and I then added some other features for my use cases. I'll close this PR to avoid more misunderstandings.

@lovelock lovelock closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants