Skip to content

Cache testsVersion by default #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnschn merged 1 commit into from
Apr 16, 2025
Merged

Cache testsVersion by default #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ async function _cmd(cmd, args, options) {
).stdout.trim();
}

async function testsVersion(config) {
async function calculateTestsVersion(config) {
try {
const tagsOutput = await _cmd('git', ['tag', '--points-at', 'HEAD'], {
cwd: config.rootDir,
Expand Down Expand Up @@ -50,6 +50,14 @@ async function testsVersion(config) {
return 'unknown';
}

async function testsVersion(config) {
if (config._cachedTestsVersion) return config._cachedTestsVersion;

const res = await calculateTestsVersion(config);
config._cachedTestsVersion = res;
return res;
}

function pentfVersion() {
// Don't use inline synchronous `require()` here, because
// that cannot be translated to ES Modules. For ES Modules
Expand All @@ -64,6 +72,7 @@ function pentfVersion() {
}

module.exports = {
calculateTestsVersion,
testsVersion,
pentfVersion,
};