Update to latest composefs-rs #1963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To unblock reverse dependency testing. (We still have the forked cfsctl, that's the only thing) Signed-off-by: Colin Walters <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the composefs-rs dependency to a newer git revision. The changes correctly update the revision in Cargo.toml and Cargo.lock. A small modification in crates/lib/src/cfsctl.rs adapts the code to an API change in the gc method of the updated dependency. The changes look correct and are necessary for compatibility with the new version of composefs-rs.
jmarrero
reviewed
Jan 29, 2026
| } | ||
| Command::GC => { | ||
| repo.gc()?; | ||
| repo.gc(&[])?; |
Contributor
There was a problem hiding this comment.
why this change is needed?
Collaborator
Author
There was a problem hiding this comment.
It came in with containers/composefs-rs#200 and if you dig in there you'll notice I asked the same question - and IMO (part of) the answer is containers/composefs-rs#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unblock reverse dependency testing.
(We still have the forked cfsctl, that's the only thing)