install: Add bootloader option
#193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For composefs backend we'd sometimes want to override the bootloader. Currently we have logic that check if an image has bootupd or not, and if it does we use grub as the bootloader, even if systemd-boot is actually installed We use this option to override the bootloader Signed-off-by: Pragyan Poudyal <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully introduces a bootloader option for the composefs_backend within the InstallOptions struct. This option is correctly configured with clap attributes to require composefs_backend and is properly translated into command-line arguments for bootc. The changes are well-aligned with the stated goal of overriding the bootloader for composefs-native backends.
Contributor
Author
|
This is in prep for bootc-dev/bootc#1913 |
cgwalters
approved these changes
Jan 27, 2026
| pub composefs_backend: bool, | ||
|
|
||
| /// Which bootloader to use for composefs-native backend | ||
| #[clap(long, requires = "composefs_backend")] |
Collaborator
There was a problem hiding this comment.
I am not sure we need to require this here, but it doesn't hurt.
Comment on lines
+77
to
+80
| if let Some(b) = &self.bootloader { | ||
| args.push("--bootloader".into()); | ||
| args.push(b.clone()); | ||
| } |
Collaborator
There was a problem hiding this comment.
Obviously fine as is but can also be args.extend(self.bootloader.map(|v| ["--bootloader", v).cloned()) probably
cgwalters
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For composefs backend we'd sometimes want to override the bootloader. Currently we have logic that check if an image has bootupd or not, and if it does we use grub as the bootloader, even if systemd-boot is actually installed
We use this option to override the bootloader