Avoid overflow further in rational::operator+=#50
Open
vedgy wants to merge 1 commit intoboostorg:developfrom
Open
Avoid overflow further in rational::operator+=#50vedgy wants to merge 1 commit intoboostorg:developfrom
vedgy wants to merge 1 commit intoboostorg:developfrom
Conversation
The added test case fails before and passes after the operator+= implementation change when sizeof(unsigned) == 4 and probably when sizeof(unsigned) == 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The added test case fails before and passes after the operator+= implementation change when
sizeof(unsigned) == 4and probably whensizeof(unsigned) == 8.I don't know whether overflowing less justifies the slower implementation. Depends on how much overflow safety is prioritized over performance.