Removing the static specifier from a function template#90
Merged
pdimov merged 1 commit intoboostorg:developfrom Oct 23, 2025
Merged
Removing the static specifier from a function template#90pdimov merged 1 commit intoboostorg:developfrom
pdimov merged 1 commit intoboostorg:developfrom
Conversation
Member
|
@pdimov could you please take a look at this fix and merge if it is OK? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #90 +/- ##
========================================
Coverage 94.73% 94.73%
========================================
Files 5 5
Lines 19 19
Branches 3 3
========================================
Hits 18 18
Misses 1 1 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presence of the static specifier on a template makes it internally linked. This template is used, in particular, to evaluate the NTTP boost::mpl_::bool_, which is needed in boost::multi_index::tag. Internal linkage prevents the use of boost::multi_index::tag and everything that depends on it in the global fragment of C++20 modules.
MRE here https://godbolt.org/z/efM6oaex9