feat: use policy-based error handling in interpolators#1245
Open
fpelliccioni wants to merge 1 commit intoboostorg:developfrom
Open
feat: use policy-based error handling in interpolators#1245fpelliccioni wants to merge 1 commit intoboostorg:developfrom
fpelliccioni wants to merge 1 commit intoboostorg:developfrom
Conversation
6a26f57 to
6e670de
Compare
Member
|
I'm not a fan of changing the API to add policy support unless you have a compelling reason. I think this could simply have replaced the current I feel like this is un-ergonomic: compared to: CC: @NAThompson |
6e670de to
48aafd1
Compare
mborland
reviewed
Feb 13, 2025
Member
mborland
left a comment
There was a problem hiding this comment.
I like this a lot more than the first iteration.
97c78c8 to
949aeb5
Compare
949aeb5 to
c3ab311
Compare
mborland
approved these changes
Feb 13, 2025
Member
mborland
left a comment
There was a problem hiding this comment.
LGTM now. I kicked off the CI run to make sure it agrees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
cubic_hermite,makima, andpchipinterpolators to useboost::math::policies::raise_domain_errorinstead of throwing exceptions.This aligns their error handling with Boost.Math’s policy-based approach.
Related PR
#1244 depends on this PR.
Summary
Replaces exceptions with policy-based error handling.
Ensures compatibility with compile-time tests where exceptions are disabled.
Next Steps
Once merged, #1244 will be unblocked and ready for review.