-
Notifications
You must be signed in to change notification settings - Fork 120
core:services:kraken: Migrate kraken to secondary venv and update its dependencies #3702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core:services:kraken: Migrate kraken to secondary venv and update its dependencies #3702
Conversation
Reviewer's GuideMigrates the Kraken service into the secondary python-venv2 workspace and modernizes its dependency stack (notably FastAPI/Pydantic), including manifest model updates and minor Docker helper cleanups, while relaxing commonwealth’s dependency constraints to match. Sequence diagram for updated manifest fetch and validation using ManifestData.model_validatesequenceDiagram
participant KrakenManifestService
participant aiohttpClientSession as aiohttp_ClientSession
participant RemoteManifestServer
participant ManifestData
KrakenManifestService->>aiohttpClientSession: get(url)
aiohttpClientSession->>RemoteManifestServer: HTTP GET /manifest
RemoteManifestServer-->>aiohttpClientSession: JSON manifest payload
aiohttpClientSession-->>KrakenManifestService: resp
KrakenManifestService->>aiohttpClientSession: resp.json(content_type=None)
aiohttpClientSession-->>KrakenManifestService: raw_manifest_data
KrakenManifestService->>ManifestData: model_validate(raw_manifest_data)
ManifestData-->>KrakenManifestService: manifest_data_instance
KrakenManifestService->>KrakenManifestService: entries = manifest_data_instance.root
Class diagram for updated Kraken manifest models with Pydantic v2 RootModelclassDiagram
class BaseModel
class RootModel~List_RepositoryEntry~{
}
class ExtensionMetadata{
}
class RepositoryEntry{
}
class ManifestData{
}
ExtensionMetadata <|-- RepositoryEntry
RootModel~List_RepositoryEntry~ <|-- ManifestData
note for ManifestData "Pydantic v1 style: class ManifestData(BaseModel) with __root__ List[RepositoryEntry] replaced by Pydantic v2 style: class ManifestData(RootModel[List[RepositoryEntry]])"
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
34e19e2 to
66355ad
Compare
66355ad to
93c3a37
Compare
Fix #3253
Closes #3276
Summary by Sourcery
Migrate the Kraken service into the secondary Python virtual environment and update its dependency stack accordingly.
Enhancements:
Build:
Summary by Sourcery
Migrate the Kraken service into the secondary Python virtual environment and refresh its dependency stack to align with shared library constraints and newer frameworks.
Enhancements:
Build: