Skip to content

Conversation

@Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Jul 9, 2024

image

@Williangalvani
Copy link
Member Author

opening as I think it is useful enough as is. I would like to make a better ui to show the current readings, but I cant think of anything good right now.

@Williangalvani Williangalvani marked this pull request as ready for review July 11, 2024 17:14
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two things that appears a bit weird, using 0 over NaN or something like it when we failed to fetch board values. And the word Gyro over gyroscope, it makes the text and reading a bit weird.. as "gyros" for the plural of gyroscopes.

@Williangalvani Williangalvani force-pushed the gyro_cal branch 2 times, most recently from 679232b to 81776bd Compare July 15, 2024 17:07
@patrickelectric patrickelectric merged commit 22025de into bluerobotics:master Jul 15, 2024
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Aug 12, 2024
@ES-Alexander ES-Alexander added docs-minimal Documentation exists but should be improved and removed docs-needed Change needs to be documented labels Oct 6, 2024
@ES-Alexander ES-Alexander added the docs-in-progress Included in an open docs PR label Apr 15, 2025
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-minimal Documentation exists but should be improved docs-in-progress Included in an open docs PR labels Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-complete Change documentation has been completed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants