[1.2]: Cherry-pick some stuff from master #2534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patrickelectric
commented
Apr 13, 2024
patrickelectric
commented
- Add path check prior to pushing repeated path in router when using logo to navigate to home #2533
- Add image check before updating bootstrap in version chooser #2528
- core: services: versionchooser: chooser: Kill bootstrap over stopping #2526
* Add a check to avoid pushing a repeated route in router stack
* Add check if the image exists prior to update the bootstrap and get unexpected error where current running bootstrap is shut down and image does not exists to up the new one
Stop can take time and as we saw in the pass, can also get in a long waiting state. Lets just kill, bootstrap operation can't go wrong. Signed-off-by: Patrick José Pereira <[email protected]>
joaomariolago
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.