Create configuration page for lights #2368
Conversation
Williangalvani
commented
Feb 6, 2024
Williangalvani
commented
core/frontend/src/components/vehiclesetup/configuration/lights.vue
Outdated
Show resolved
Hide resolved
| lights1_new_param(new_param_name: string | undefined) { | ||
| if (new_param_name) { | ||
| // reset any other parameter using lights1 to undefined | ||
| for (const old_param of this.servo_params) { | ||
| if (old_param.name === new_param_name) { | ||
| continue | ||
| } | ||
| if (old_param.value === Lights.Lights1) { | ||
| // set the old parameter to DISABLED | ||
| mavlink2rest.setParam(old_param.name, Lights.DISABLED, autopilot_data.system_id) | ||
| } | ||
| } | ||
| mavlink2rest.setParam(new_param_name, Lights.Lights1, autopilot_data.system_id) | ||
| } | ||
| }, | ||
| lights2_new_param(new_param_name: string | undefined) { | ||
| if (new_param_name) { | ||
| // reset any other parameter using lights2 to undefined | ||
| for (const old_param of this.servo_params) { | ||
| if (old_param.name === new_param_name) { | ||
| continue | ||
| } | ||
| if (old_param.value === Lights.Lights2) { | ||
| // set the old parameter to DISABLED | ||
| mavlink2rest.setParam(old_param.name, Lights.DISABLED, autopilot_data.system_id) | ||
| } | ||
| } | ||
| mavlink2rest.setParam(new_param_name, Lights.Lights2, autopilot_data.system_id) | ||
| } |
There was a problem hiding this comment.
Can we encapsulate this in a single function for both lights ?
| <v-card> | ||
| <v-card-title> Joystick steps </v-card-title> | ||
| <v-card-text> | ||
| How many button presses it takes to go from 0% to 100% brightness. |
There was a problem hiding this comment.
I believe that asking the user a percentage per step over the number of buttons press is more friendly. Maybe rephrasing it helps.
There was a problem hiding this comment.
improved the wording and added a live-updated percentage
Williangalvani
force-pushed
the
lights
branch
from
3c5a8ec to
9a792c4
Compare
|
updated |
| return { | ||
| lights1_new_param: undefined as (string | undefined), // item-value must be a primitive | ||
| lights2_new_param: undefined as (string | undefined), | ||
| steps_new_value: 0, |
There was a problem hiding this comment.
could we use a default value, like 10 ?
Other than that is just weird to start with 0 steps.
There was a problem hiding this comment.
that should never happen, as we set it to the parameter value both when mounting (if the param is available) or when we detect a parameter change in the watcher. but I did update it anyway.
There was a problem hiding this comment.
When you configure it for the first time, if the lights are not configured, it starts with 0.
Williangalvani
force-pushed
the
lights
branch
from
9a792c4 to
889ed64
Compare
|
Can we add a slider for the steps? Could also be nice to have a little graph showing the steps visually (with display options for both linear and Lumen-exponential brightness outputs). It might make sense to have the channel controls in the top row, and then the steps slider + graph in a second row (instead of the current approach with everything in a single row). Thinking something like this: |
|
There is also another thing, the page end up showing for rover as well, should we remove it ? |
Fancy! |
patrickelectric
left a comment
patrickelectric
left a comment
There was a problem hiding this comment.
We can move further required changes to issues.
ES-Alexander
added
docs-minimal
ES-Alexander
added
docs-complete
3 participants
