Skip to content

fix(revme): validate state root hash for invalid transactions #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Himess wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(revme): validate state root hash for invalid transactions #3388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 17 additions & 21 deletions bins/revme/src/cmd/statetest/runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,30 +238,26 @@ fn check_evm_execution(
print_json(Some(e));
})?;

// If exception was expected and occurred, we're done
if exception_expected {
print_json(None);
return Ok(());
}

// Validate output if execution succeeded
if let Ok(result) = exec_result {
validate_output(expected_output, result).inspect_err(|e| {
print_json(Some(e));
})?;
}
// Validate output if execution succeeded (skip if exception was expected)
if !exception_expected {
if let Ok(result) = exec_result {
validate_output(expected_output, result).inspect_err(|e| {
print_json(Some(e));
})?;
}

// Validate logs root
if validation.logs_root != test.logs {
let error = TestErrorKind::LogsRootMismatch {
got: validation.logs_root,
expected: test.logs,
};
print_json(Some(&error));
return Err(error);
// Validate logs root (only when no exception expected)
if validation.logs_root != test.logs {
let error = TestErrorKind::LogsRootMismatch {
got: validation.logs_root,
expected: test.logs,
};
print_json(Some(&error));
return Err(error);
}
}

// Validate state root
// Validate state root (always, even when exception was expected)
if validation.state_root != test.hash {
let error = TestErrorKind::StateRootMismatch {
got: validation.state_root,
Expand Down
Loading