Skip to content

Conversation

@RyanBGG
Copy link
Contributor

@RyanBGG RyanBGG commented Jan 30, 2026

When storage_by_account_id misses the BAL layer, it previously called self.database.storage() directly, bypassing the Cache and Bundle layers. This could return stale data when storage values have been modified in Cache or Bundle but not yet synced to BAL.
The fix changes this to call self.storage(), which correctly traverses the full lookup chain: Cache → Bundle → Database. This is consistent with the storage() method implementation and matches the expected behavior documented in the Database trait's default implementation (lines 67-80).

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 30, 2026

Merging this PR will not alter performance

✅ 173 untouched benchmarks


Comparing RyanBGG:DBfix (bd9f06e) with main (add1b54)

Open in CodSpeed

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find

@rakita rakita merged commit cb06ba8 into bluealloy:main Feb 2, 2026
31 checks passed
@github-actions github-actions bot mentioned this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants