docs: clarify gmp uses dynamic linking (no GPL implications) #3383
+2
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove GPL license warning from README (gmp uses dynamic linking) - Update feature comments in crates/precompile/Cargo.toml and crates/revm/Cargo.toml Amp-Thread-ID: https://ampcode.com/threads/T-019c101d-e03c-7564-a1bc-81008386830a Co-authored-by: Amp <[email protected]>
gakonst
force-pushed
the
dani/docs-gmp-dynamic-linking
branch
from
6678905 to
97d717d
Compare
DaniPopes
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README incorrectly states that using the
gmpfeature compiles GPL code. Since PR #3250, gmp is dynamically linked at runtime, so there are no GPL license implications for binaries using this feature.Changes