Skip to content

Fix tests #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephanErb merged 2 commits into from
Dec 22, 2025
Merged

Fix tests #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2393ca9
Improve compatibility of tests with newer version of pip
matthias-bach-by Dec 15, 2025
bbcace5
Add missing test dependency for Python 3.13
matthias-bach-by Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ pytest-cov
pytest-mock
mock
devpi-plumber[test]>=0.4.3
legacy-cgi
2 changes: 2 additions & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ lazy==1.6
# via
# devpi-common
# devpi-server
legacy-cgi==2.6.4
# via -r requirements.in
mock==5.2.0
# via -r requirements.in
nh3==0.2.21
Expand Down
31 changes: 20 additions & 11 deletions tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import xml.etree.ElementTree as ET

import pytest
import requests

from mock import patch
from devpi_plumber.server import TestServer
Expand Down Expand Up @@ -187,20 +188,28 @@ def test_reports_junit_xml(devpi, tmpdir):
_assert_junit_xml_content(junit_filename)


def test_handles_non_ascii_build_output(devpi, tmpdir, monkeypatch):
monkeypatch.setenv('PIP_INDEX_URL', devpi.url + '/' + PURE_INDEX)
def test_handles_non_ascii_build_output(tmpdir, monkeypatch):

with DevpiClient(devpi.server_url + '/' + PURE_INDEX,
USER,
PASSWORD) as client:
client.upload('tests/fixture/non-ascii_package/dist/non-ascii-package-0.1.dev1.tar.gz')
with TestServer(USERS, {
PURE_INDEX: {'bases': '/root/pypi'},
INDEX: {'bases': ''},
}) as devpi:
sdist_index = devpi.url + '/' + PURE_INDEX

junit_filename = str(tmpdir.join('junit.xml'))
monkeypatch.setenv('PIP_INDEX_URL', sdist_index)

# our main assertion is that the main does not fail
main(['tests/fixture/sample_non-ascii.txt', devpi.url + '/' + INDEX,
'--user={}'.format(USER),
'--password={}'.format(PASSWORD), '--junit-xml', junit_filename])
# trigger retrieval of setuptools from upstream as that can take forever
requests.get(sdist_index + '/+simple/setuptools/', timeout=300).raise_for_status()

with DevpiClient(sdist_index, USER, PASSWORD) as client:
client.upload('tests/fixture/non-ascii_package/dist/non-ascii-package-0.1.dev1.tar.gz')

junit_filename = str(tmpdir.join('junit.xml'))

# our main assertion is that the main does not fail
main(['tests/fixture/sample_non-ascii.txt', devpi.url + '/' + INDEX,
'--user={}'.format(USER),
'--password={}'.format(PASSWORD), '--junit-xml', junit_filename])

# check that the build failure shows up in the build output
assert 'No non-ascii 4 you!' in open(junit_filename).read()
Expand Down