Missed a couple of places that hard code J for the newline key #6853
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug from PR #5956 where two locations continued to hardcode the 'j' key for newline entry instead of using the new configurable GOOSE_CLI_NEWLINE_KEY environment variable.
Changes:
- Updates the key binding setup in
input.rsto useget_newline_key()instead of hardcoded 'j' - Updates the user hint in
completion.rsto dynamically display the configured newline key
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/goose-cli/src/session/input.rs | Updates the rustyline key binding to use the configurable newline key instead of hardcoded 'j' |
| crates/goose-cli/src/session/completion.rs | Updates the hint message to display the actual configured newline key (e.g., "Ctrl-N") instead of always showing "Ctrl-J" |
Signed-off-by: Trae Robrock <[email protected]>
trobrock
force-pushed
the
fix-newline-key
branch
from
cc2242a to
8c854bf
Compare
zanesq
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From #5956 there were a couple spots that were missed and don't use the new configuration preventing this from working properly.
Type of Change
AI Assistance
Testing
Manual testing locally
Related Issues
Relates to #5956
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
Before:
After: