fix[format/openai]: return error on empty msg. #6511
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yelsin Sepulveda <[email protected]>
The-Best-Codes
force-pushed
the
yorisoft/fix_copilot_no_credit_empty_response
branch
from
e6707bc to
ec39c12
Compare
The-Best-Codes
approved these changes
Jan 15, 2026
jamadeo
reviewed
Jan 15, 2026
Collaborator
jamadeo
left a comment
jamadeo
left a comment
There was a problem hiding this comment.
I could see treating it as an error if we can't get a message from the payload.
But are sure we aren't dropping an error somewhere else from Github when we hit this? I'd be surprised if GH isn't telling us the real error somewhere.
Collaborator
|
Thanks Jack. |
Contributor
Author
|
@The-Best-Codes |
Yorisoft
force-pushed
the
yorisoft/fix_copilot_no_credit_empty_response
branch
3 times, most recently
from
f08f474 to
b79df2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Return an error message when receiving an empty response.
Type of Change
AI Assistance
Testing
Manual testing - Observers expected changes
Related Issues
Relates to: fixes #6470
Screenshots/Demos (for UX changes)
Before:
After:
