allow --with-builtin extension on cli resume #6502
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where resuming a session with --with-builtin flags would incorrectly prompt the user about missing extensions, even though those extensions are being explicitly provided via CLI arguments. The fix adds a check to skip the "missing extension" warning for extensions that are supplied through the CLI.
Changes:
- Modified
check_missing_extensions_or_exitto accept a set of CLI-provided extension names - Extensions provided via CLI are now excluded from the missing extensions check during session resume
| } | ||
|
|
||
| // Collect CLI-provided extension names to avoid false "missing" warnings on resume | ||
| let cli_extension_names: HashSet<String> = session_config.builtins.iter().cloned().collect(); |
There was a problem hiding this comment.
The variable collects only builtin extensions, but stdio and streamable_http extensions (added via session_config.extensions and session_config.streamable_http_extensions) are parsed and added later (lines 537-589). However, these other extension types don't go through check_missing_extensions_or_exit, so this is actually correct. The variable name cli_extension_names could be misleading though - consider renaming to cli_builtin_names to clarify it only contains builtin extensions.
Signed-off-by: Evanfeenstra <[email protected]>
Evanfeenstra
force-pushed
the
ef/fix-builtin-extensions-on-resume
branch
from
dc5fd8d to
8355c3a
Compare
Signed-off-by: Evanfeenstra <[email protected]>
|
maybe this is already solved with #6412 .. but still, this should not be an error at all IMO |
I stand corrected from our thread in Discord. only half the problem is resolved with 6412. After looking at your PR, this would solve the problem fully |
2 participants
Summary
Included builtin extension names in the check_missing_extensions_or_exit check, so that you can add
--with-builtinto cli call while also including--resumeThe problem:
goose run --with-builtin developer --output-format stream-json --name session1 -t "read the readme"goose run --with-builtin developer --output-format stream-json --name session1 -t "summarize our convo" --resumeresults in: "Extension(s) developer from previous session are no longer available. Restore for this session?"
Type of Change
AI Assistance
Testing
Yes, I verified this works by running the flow locally from ./target/debug/goose, and the interative cli prompt did not showup
Related Issues
Relates to #ISSUE_ID
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
Before:
After: