feat(gcp-vertex): add model list with org policy filtering #6393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabi
force-pushed
the
vertex_fix
branch
2 times, most recently
from
3837d5b to
a02717d
Compare
Contributor
Author
|
@jamadeo Hey PTAL. This removes some cruft and makes is easier to select/provide models when configuring gcp_vertex_ai provider. |
jamadeo
approved these changes
Jan 16, 2026
| let mut model_items: Vec<(String, String, &str)> = | ||
| models.iter().map(|m| (m.clone(), m.clone(), "")).collect(); | ||
|
|
||
| if provider_meta.allows_unlisted_models { |
Collaborator
There was a problem hiding this comment.
Maybe we should just always allow this for any provider? Since we now have the ability, we might as well let the user opt to do this
Contributor
Author
There was a problem hiding this comment.
I think most providers expose a model‑listing API (Vertex AI is the exception), so offering an ‘unlisted model’ option for those providers is less useful and can lead to invalid selections and subsequent error when configuring the provider.
- Add static KNOWN_MODELS list for Claude and Gemini models - Filter models by GCP org policy (constraints/vertexai.allowedModels) - Preserve unlisted model entry via allows_unlisted_models flag - Replace ClaudeVersion/GeminiVersion enums with simple string storage Note: Vertex AI does not provide a public REST API to list available foundation/publisher models, hence the static KNOWN_MODELS approach. Signed-off-by: rabi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: Vertex AI does not provide a public REST API to list available foundation/publisher models, hence the static KNOWN_MODELS approach.
Type of Change
AI Assistance
Testing
Unit tests and tested with Vertex AI.