Skip to content

feat: Configure dynamic loglevel update #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nssherpa merged 2 commits into from
Feb 24, 2026
+28 −2
Merged

feat: Configure dynamic loglevel update #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ebfe0f
feat: Make changing log level dynamic
nssherpa Feb 24, 2026
6ca1fab
fix: Address comments
nssherpa Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions cmd/cachewd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,21 @@ func newMux(ctx context.Context, cr *cache.Registry, sr *strategy.Registry, prov
_, _ = w.Write([]byte("OK")) //nolint:errcheck
})

mux.HandleFunc("GET /admin/log/level", func(w http.ResponseWriter, _ *http.Request) {
_, _ = fmt.Fprintln(w, logging.GetLevel().String())
})

mux.HandleFunc("PUT /admin/log/level", func(w http.ResponseWriter, r *http.Request) {
var level slog.Level
if err := level.UnmarshalText([]byte(strings.TrimSpace(r.FormValue("level")))); err != nil {
http.Error(w, fmt.Sprintf("invalid level: %s", err), http.StatusBadRequest)
return
}
logging.SetLevel(level)
logging.FromContext(r.Context()).Info("Log level changed", "level", level)
_, _ = fmt.Fprintln(w, logging.GetLevel().String())
})

if err := config.Load(ctx, cr, sr, providersConfigHCL, mux, vars); err != nil {
return nil, errors.Errorf("load config: %w", err)
}
Expand Down
15 changes: 13 additions & 2 deletions internal/logging/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,23 @@ type Config struct {
Remap map[string]string `hcl:"remap,optional" help:"Remap field names from old to new (e.g., msg=message, time=timestamp)."`
}

var levelVar = &slog.LevelVar{} //nolint:gochecknoglobals

type logKey struct{}

// SetLevel sets the global log level at runtime.
func SetLevel(level slog.Level) { levelVar.Set(level) }

// GetLevel returns the current global log level.
func GetLevel() slog.Level { return levelVar.Level() }

// Configure sets up logging with the given config and returns the logger and updated context.
func Configure(ctx context.Context, config Config) (*slog.Logger, context.Context) {
levelVar.Set(config.Level)

var handler slog.Handler
if config.JSON {
options := &slog.HandlerOptions{Level: config.Level}
options := &slog.HandlerOptions{Level: levelVar}
if len(config.Remap) > 0 {
options.ReplaceAttr = func(groups []string, a slog.Attr) slog.Attr {
if len(groups) > 0 {
Expand All @@ -35,7 +46,7 @@ func Configure(ctx context.Context, config Config) (*slog.Logger, context.Contex
handler = &messageHandler{inner: slog.NewJSONHandler(os.Stdout, options)}
} else {
handler = tint.NewHandler(os.Stderr, &tint.Options{
Level: config.Level,
Level: levelVar,
ReplaceAttr: func(groups []string, a slog.Attr) slog.Attr {
if a.Key == slog.TimeKey && len(groups) == 0 {
return slog.Attr{}
Expand Down