Enable scoverage in github actions and add coveralls plus badge#321
Draft
mdedetrich wants to merge 1 commit intobkirwi:mainfrom
Draft
Enable scoverage in github actions and add coveralls plus badge#321mdedetrich wants to merge 1 commit intobkirwi:mainfrom
mdedetrich wants to merge 1 commit intobkirwi:mainfrom
Conversation
mdedetrich
commented
Jul 15, 2021
| ) | ||
| ThisBuild / githubWorkflowArtifactUpload := false | ||
| ThisBuild / githubWorkflowPublishTargetBranches := Seq() | ||
| // This is causing problems with env variables being passed in, see |
Contributor
Author
There was a problem hiding this comment.
I am not sure why you specifically disable sbt thin client but in my experience I had to disable it because it doesn't pass ENV variables (which is needed for coveralls) so I just added a comment here explaining why
mdedetrich
force-pushed
the
enable-scoverage-add-coveralls
branch
from
80fadee to
593ce06
Compare
mdedetrich
force-pushed
the
enable-scoverage-add-coveralls
branch
from
593ce06 to
258eab5
Compare
Contributor
Author
|
Hmm, so it seems that this is not working because scoverage doesn't support Scala3 yet. Theoritically its possible to put conditionals so that scoverage/scoveralls is only run for Scala2 but since this is non urgent I think just waiting for Scala3 support in scoverage is better. |
Contributor
Author
|
Upstream issue at scoverage/scalac-scoverage-plugin#299 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following things