-
Notifications
You must be signed in to change notification settings - Fork 938
[PM-31835] feat: add generator copy password field on send #6508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: PM-31614/update-add-edit-send-ui-email-auth
Are you sure you want to change the base?
[PM-31835] feat: add generator copy password field on send #6508
Conversation
…835/add-generator-copy-password-field-on-send
|
Great job! No new security vulnerabilities introduced in this pull request |
|
Sorry, nosy user alert. But as I tracked this, I think there already was a fix for this: #6435 (PS: or maybe that was on a component that now gets replaced?!) But as this #6505 just was reported, it seems to miss the usual "Check password for data breaches" button directly below / attached to that password field. (BTW, like also in your screenshot @aj-rosado) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6508 +/- ##
==========================================
- Coverage 86.36% 86.34% -0.03%
==========================================
Files 767 781 +14
Lines 56045 56570 +525
Branches 8152 8183 +31
==========================================
+ Hits 48405 48845 +440
- Misses 4800 4882 +82
- Partials 2840 2843 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
That component is being replaced, this change is to add that same buttons on the new component. |

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-31835
📔 Objective
Add copy and generator button to the password field on the new send's password AuthType
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes