Skip to content

Conversation

@aj-rosado
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-31835

📔 Objective

Add copy and generator button to the password field on the new send's password AuthType

📸 Screenshots

Screenshot_1770736912

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@aj-rosado aj-rosado requested review from a team and david-livefront as code owners February 10, 2026 15:27
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels Feb 10, 2026
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details8a490f82-0992-49ee-ab7d-e3ba339ccf3e

Great job! No new security vulnerabilities introduced in this pull request

@pamperer562580892423
Copy link

pamperer562580892423 commented Feb 10, 2026

Sorry, nosy user alert. But as I tracked this, I think there already was a fix for this: #6435 (PS: or maybe that was on a component that now gets replaced?!)

But as this #6505 just was reported, it seems to miss the usual "Check password for data breaches" button directly below / attached to that password field. (BTW, like also in your screenshot @aj-rosado)

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 94.95798% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.34%. Comparing base (eb24a50) to head (042a104).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...tools/feature/send/addedit/AddEditSendViewModel.kt 85.71% 5 Missing and 2 partials ⚠️
...ls/feature/send/addedit/util/SendViewExtensions.kt 50.00% 2 Missing and 1 partial ⚠️
...d/addedit/components/AddEditSendAuthTypeChooser.kt 97.72% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6508      +/-   ##
==========================================
- Coverage   86.36%   86.34%   -0.03%     
==========================================
  Files         767      781      +14     
  Lines       56045    56570     +525     
  Branches     8152     8183      +31     
==========================================
+ Hits        48405    48845     +440     
- Misses       4800     4882      +82     
- Partials     2840     2843       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aj-rosado aj-rosado changed the base branch from main to PM-31614/update-add-edit-send-ui-email-auth February 10, 2026 18:52
@aj-rosado
Copy link
Contributor Author

Sorry, nosy user alert. But as I tracked this, I think there already was a fix for this: #6435 (PS: or maybe that was on a component that now gets replaced?!)

But as this #6505 just was reported, it seems to miss the usual "Check password for data breaches" button directly below / attached to that password field. (BTW, like also in your screenshot @aj-rosado)

That component is being replaced, this change is to add that same buttons on the new component.
Thank you for being aware and raising this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants